This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
added a warning log , for well_known_server_name,well_known_server_name when they dont have prefix #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dont have http || https prefix
S7evinK
reviewed
Oct 24, 2023
clientapi/routing/routing.go
Outdated
| @@ -129,6 +129,10 @@ func Setup( | |||
| })).Methods(http.MethodGet, http.MethodOptions) | |||
| } | |||
|
|
|||
| if !strings.HasPrefix(string(cfg.Matrix.ServerName), "http://") || !strings.HasPrefix(string(cfg.Matrix.ServerName), "https://") { | |||
| logrus.Warn("The well_known_server_name does not start with http:// or https:// does not start with 'http://' or 'https://'. Some clients may fail to connect.") | |||
There was a problem hiding this comment.
Looks like accidentally duplication? (as well as well_known_client_name instead of well_known_server_name)
Also better to put this inside the if cfg.Matrix.WellKnownClientName != "" { block above. (same for the federation change below)
|
Right, updated to only check client well-known, as that's the only well-known that actually needs a http/https prefix. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
==========================================
- Coverage 65.08% 65.08% -0.01%
==========================================
Files 508 508
Lines 57388 57392 +4
==========================================
+ Hits 37352 37353 +1
Misses 16113 16113
- Partials 3923 3926 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing this #3180
added a warning log when either well_known_server_name, well_known_server_name: dont have a prefix in them
[email protected]