Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Refactor and add unit tests for roomserver/query/query.go #929

Open
kegsay opened this issue Mar 19, 2020 · 1 comment
Open

Refactor and add unit tests for roomserver/query/query.go #929

kegsay opened this issue Mar 19, 2020 · 1 comment
Labels
C-Roomserver T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. tests Issues related to tests. Missing/Flakey/etc

Comments

@kegsay
Copy link
Member

kegsay commented Mar 19, 2020

to make it much easier to see what is going on

@kegsay
Copy link
Member Author

kegsay commented Mar 19, 2020

  • the database methods are all over the place and to pull out basic info requires 3-4 calls
  • the prolific use of "here's a pointer to a response, write whatever you want as a side-effect when I call you!"
  • the constant manual type-casting to get []Event into anywhere, roomserver has it's own types.Event :/
  • the lack of any unit tests beyond getAuthChain
  • the database interface is so huge that it makes it difficult to see exactly what each query impl actually needs from the database, sometimes it's very little

@kegsay kegsay added tests Issues related to tests. Missing/Flakey/etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Roomserver T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. tests Issues related to tests. Missing/Flakey/etc
Projects
None yet
Development

No branches or pull requests

1 participant