Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add unit tests for roomserver/query/query.go #929

Open
matrixbot opened this issue Oct 31, 2024 · 1 comment
Open

Refactor and add unit tests for roomserver/query/query.go #929

matrixbot opened this issue Oct 31, 2024 · 1 comment
Labels
C-Roomserver T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. tests Issues related to tests. Missing/Flakey/etc

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @kegsay at matrix-org/dendrite#929.

to make it much easier to see what is going on

@matrixbot matrixbot added C-Roomserver T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. tests Issues related to tests. Missing/Flakey/etc labels Oct 31, 2024
@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @kegsay at matrix-org/dendrite#929 (comment).

  • the database methods are all over the place and to pull out basic info requires 3-4 calls
  • the prolific use of "here's a pointer to a response, write whatever you want as a side-effect when I call you!"
  • the constant manual type-casting to get []Event into anywhere, roomserver has it's own types.Event :/
  • the lack of any unit tests beyond getAuthChain
  • the database interface is so huge that it makes it difficult to see exactly what each query impl actually needs from the database, sometimes it's very little

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Roomserver T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. tests Issues related to tests. Missing/Flakey/etc
Projects
None yet
Development

No branches or pull requests

1 participant