Add support for comparing multiple baseline images #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoRoth
force-pushed
the
multi_baseline
branch
2 times, most recently
from
472d92a
to
ac84260
Compare
|
Not entirely sure why the tests are failing. Some of those I'm relatively sure I didn't even touch? |
The failing compare with the lowest rms value will be used for the summary. A shape-mismatch has infinitely low "rms" and will be preferred over any comparison mismatch.
This should be fixed by #162 |
|
Ah, yeah. Just confirmed that they're failing on master as well for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #149, this is our forward-ported code to deal with multiple valid baseline images.
It's not yet tested, just a mostly blind forward-port that deals with the new summary.
The failing compare with the lowest rms value will be used for the summary.
A shape-mismatch has infinitely low "rms" and will be preferred over any comparison mismatch.