Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to support Java 8 as the minimum requirement #70

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

matoos32
Copy link
Owner

Modifications to support Java 8 as the minimum requirement as per JFreeChart 1.5.3.

The build using JDK 8 was broken.

  • Remove @Deprecated annotation elements not supported by Java 8.
  • Remove use of Set.of() not supported by Java 8.

…eeChart 1.5.3

* Remove @deprecated annotation elements not supported by Java 8.
* Remove use of Set.of() not supported by Java 8.
@matoos32
Copy link
Owner Author

Tested on Ubuntu 20.04.05 LTS with OpenJDK 1.8.0_352.

Observed an unrelated fatal OutOfMemoryError when launching the gapless annotation demo chart. Was related to calling XYShapeAnnotation.draw(). This does not occur when running with Java 11 even if built with JDK 8. Will merge but raise a ticket.

@matoos32 matoos32 merged commit 48fdcab into develop Nov 23, 2022
@matoos32 matoos32 deleted the remove-unsupported-java8-constructs branch November 23, 2022 22:03
@matoos32
Copy link
Owner Author

I created bug ticket #71 to track the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant