Skip to content

Commit

Permalink
Merge pull request #335 from matomo-org/334-fix-migration-script
Browse files Browse the repository at this point in the history
Fixed migration script error for installs without prefix
  • Loading branch information
AltamashShaikh authored Mar 29, 2023
2 parents d15491b + d166e14 commit fda516d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# LoginLdap Changelog

#### LoginLdap 4.7.3
* Fixed migration script error for installs without prefix

#### LoginLdap 4.7.2
* Fixed _isLDAPUser option not being deleted from option table on user deletion.

Expand Down
4 changes: 2 additions & 2 deletions Updates/4.7.2.php → Updates/4.7.3.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

/**
*/
class Updates_4_7_2 extends Updates
class Updates_4_7_3 extends Updates
{
/**
* @var MigrationFactory
Expand All @@ -44,7 +44,7 @@ public function doUpdate(Updater $updater)

$searchPattern = UsersManagerAPI::OPTION_NAME_PREFERENCE_SEPARATOR . UserMapper::USER_PREFERENCE_NAME_IS_LDAP_USER;
$db = Db::get();
$optionValues = $db->fetchAll("Select option_name from $optionTable where option_name like '%$searchPattern'");
$optionValues = $db->fetchAll("Select option_name from `$optionTable` where option_name like '%$searchPattern'");
foreach ($logins as $login) {
$loginNames[$login['login']] = 1;
}
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "LoginLdap",
"version": "4.7.2",
"version": "4.7.3",
"description": "LDAP authentication and synchronization for Matomo.",
"theme": false,
"keywords": ["ldap", "login", "authentication", "active", "directory", "kerberos", "sso"],
Expand Down

0 comments on commit fda516d

Please sign in to comment.