Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled re-import date range feature for GA3, #L3-761 #537

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Disabled re-import date range feature for GA3
Fixes: #L3-761

Review

@araichyk
Copy link

I noticed that this change was made in the 5.x-dev branch but is not reflected here in the 4.x-dev branch. Should we apply the same change here?
image

Copy link

@araichyk araichyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, but it might be nothing.

I don't have the proper setup to test this, but the changes look good and seem to match the 5.x-dev changes 👍

@AltamashShaikh
Copy link
Contributor Author

I noticed that this change was made in the 5.x-dev branch but is not reflected here in the 4.x-dev branch. Should we apply the same change here? image

@araichyk This changed was made as vue:build was giving an error, but the same worked fine in 4.x-dev and hence didn't update that part.

@AltamashShaikh AltamashShaikh merged commit eb76f72 into 4.x-dev Jul 12, 2024
5 checks passed
@AltamashShaikh AltamashShaikh deleted the L3-761-disable-reimport-ga3 branch July 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants