Skip to content

Commit

Permalink
Adding check for core version to avoid requiring minimum version incr…
Browse files Browse the repository at this point in the history
…ease
  • Loading branch information
snake14 committed Sep 9, 2024
1 parent 0bd3270 commit 9787b4e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion RecordBuilders/CustomVariables.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Piwik\Plugins\CustomVariables\Archiver;
use Piwik\Plugins\CustomVariables\Model;
use Piwik\Tracker\GoalManager;
use Piwik\Version;

class CustomVariables extends RecordBuilder
{
Expand Down Expand Up @@ -94,7 +95,9 @@ protected function aggregateCustomVariable(DataTable $record, array &$metadata,
$query = $logAggregator->queryActionsByDimension($dimensions, $where, $additionalSelects);
$this->aggregateFromActions($record, $metadata, $metadataFlat, $query, $keyField, $valueField);

$query = $logAggregator->queryConversionsByDimension($dimensions, $where, [], [], false, false, true);
$query = version_compare(Version::VERSION, '5.2.0-b1', '>=')
? $logAggregator->queryConversionsByDimension($dimensions, $where, [], [], false, false, true)
: $logAggregator->queryConversionsByDimension($dimensions, $where);
$this->aggregateFromConversions($record, $query, $keyField, $valueField);
}

Expand Down

0 comments on commit 9787b4e

Please sign in to comment.