Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry picked Fixed alert condition not reloading on site change #146

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Cherry picked Fixed alert condition not reloading on site change #146

merged 3 commits into from
Aug 25, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Cherry picked Fixed alert condition not reloading on site change
Fixes: #PG-2967, #142

Review

@AltamashShaikh AltamashShaikh marked this pull request as ready for review August 24, 2023 02:17
snake14
snake14 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and functional confirmed that the options updated when a different site was selected 👍

@AltamashShaikh AltamashShaikh merged commit d080848 into 4.x-dev Aug 25, 2023
5 checks passed
@AltamashShaikh AltamashShaikh deleted the cherrypick-145 branch August 25, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @snake14