Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new hits metric to Actions.get report and All Websites Dashboard #22731

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 31, 2024

Description:

This PR introduce a new record builder to archive the hits metric as part of the Actions plugin.
Furthermore this metric has been added to the Actions.get report and to all reports and the UI of the All Websites Dashboard.

To ensure this metric is correctly displayed without further interaction, the hits metric will be automatically invalidated through an update script for the current year.

fixes #18978

Note: This will require some updates to test in submodules. Will create PRs for those, once the review here was done.

Review

@sgiehl sgiehl added this to the 5.2.0 milestone Oct 31, 2024
@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 31, 2024
@sgiehl sgiehl requested a review from a team October 31, 2024 15:18
@sgiehl sgiehl requested a review from a team November 4, 2024 11:31
michalkleiner
michalkleiner previously approved these changes Nov 8, 2024
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally comparing an instance without the feature and with the feature, looked at the screenshots and some of the xml reports, ran the query manually for a custom date range to confirm getting the same number as in the UI.

@michalkleiner
Copy link
Contributor

@sgiehl can you please resolve the merge conflicts that probably come from submodule updates done in the interim.

Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests within the SystemTestsPlugins suites are from submodule plugins that need to be adjusted in separate repositories. The rest looks good, thanks @sgiehl!

@sgiehl sgiehl merged commit bc57393 into 5.x-dev Nov 11, 2024
23 of 26 checks passed
@sgiehl sgiehl deleted the dev-14058 branch November 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hits to all websites dashboard metrics
2 participants