-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new hits metric to Actions.get report and All Websites Dashboard #22731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally comparing an instance without the feature and with the feature, looked at the screenshots and some of the xml reports, ran the query manually for a custom date range to confirm getting the same number as in the UI.
@sgiehl can you please resolve the merge conflicts that probably come from submodule updates done in the interim. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing tests within the SystemTestsPlugins suites are from submodule plugins that need to be adjusted in separate repositories. The rest looks good, thanks @sgiehl!
Description:
This PR introduce a new record builder to archive the hits metric as part of the Actions plugin.
Furthermore this metric has been added to the Actions.get report and to all reports and the UI of the All Websites Dashboard.
To ensure this metric is correctly displayed without further interaction, the hits metric will be automatically invalidated through an update script for the current year.
fixes #18978
Note: This will require some updates to test in submodules. Will create PRs for those, once the review here was done.
Review