-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ollama images #59
Merged
Merged
Ollama images #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor `messageHistory` to be agnostic of the image encoding. * Add backend encoding of images to `openAIChat`, `azureChat`, and `ollamaChat`. * Add image test points to the test files. Open question: Can we reliably detect which Ollama models support vision?
Preinstall bakllava, to have a vision model
MiriamScharnke
approved these changes
Jul 25, 2024
MiriamScharnke
requested changes
Jul 26, 2024
Co-authored-by: MiriamScharnke <[email protected]>
vpapanasta
approved these changes
Jul 29, 2024
MiriamScharnke
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messageHistory
to be agnostic of the image encoding.openAIChat
,azureChat
, andollamaChat
.As for the image encoding, Azure expects messages like this:
where
<image URL>
can be a “normal” URL like"https://somewhere.tld/filepath.png"
or an inline URL like"data:image/jpeg;base64,{base64_image}"
.Multiple images can be in the same
"content"
array or in multiple"user"
messages, experiments say. With this change, we are sending them in one"user"
message.The image encoding for OpenAI is the same as for Azure.
Ollama wants to get images in a different format: