Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra tests to increase code coverage in ollamaChat and azureChat #47

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

vpapanasta
Copy link
Member

No description provided.

@vpapanasta vpapanasta requested a review from ccreutzi June 27, 2024 16:16
@vpapanasta vpapanasta self-assigned this Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.11%. Comparing base (5882528) to head (e43cb20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   96.78%   97.11%   +0.32%     
==========================================
  Files          38       38              
  Lines        1246     1246              
==========================================
+ Hits         1206     1210       +4     
+ Misses         40       36       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ccreutzi ccreutzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we can somehow test that the system prompt is actually used.

@vpapanasta
Copy link
Member Author

I'm wondering if we can somehow test that the system prompt is actually used.

Good question. It would be great to check if the system prompt is part of messagesStruct which is used as input to llms.internal.callAzureChatAPI. However, we cannot somehow access messagesStruct externally.

@vpapanasta vpapanasta merged commit f8acb3a into main Jun 27, 2024
1 check passed
@vpapanasta vpapanasta deleted the codeCoverageIncreaseOllamaAzure branch July 9, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants