Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move size check into arguments block #43

Merged
merged 1 commit into from
Jun 17, 2024
Merged

move size check into arguments block #43

merged 1 commit into from
Jun 17, 2024

Conversation

ccreutzi
Copy link
Member

Use mustBeValidSize in arguments block instead of validateSizeNVP later.

Closes #29.

Use `mustBeValidSize` in arguments block instead of `validateSizeNVP` later.
@ccreutzi ccreutzi requested review from debymf and vpapanasta June 12, 2024 12:53
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.98%. Comparing base (93a39af) to head (a6c86c8).

Files Patch % Lines
tests/topenAIImages.m 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   61.06%   60.98%   -0.08%     
==========================================
  Files          33       33              
  Lines        2052     2048       -4     
==========================================
- Hits         1253     1249       -4     
  Misses        799      799              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccreutzi ccreutzi requested a review from adulai June 14, 2024 10:10
@ccreutzi ccreutzi merged commit 38edd99 into main Jun 17, 2024
1 check passed
@ccreutzi ccreutzi deleted the size-check branch June 17, 2024 10:19
Copy link
Collaborator

@adulai adulai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding comment to see if that will update my reviewer status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mustBeValidSize in openAIImages is unused
5 participants