Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websave to get images #40

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Websave to get images #40

merged 2 commits into from
Jun 6, 2024

Conversation

ccreutzi
Copy link
Member

@ccreutzi ccreutzi commented Jun 5, 2024

Using imread on the openAI DALL•E URLs is surprisingly unreliable. Use websave instead, which seems to work much better.

Closes #35

@ccreutzi ccreutzi requested review from debymf and vpapanasta June 5, 2024 15:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (05ac9a9) to head (93fcbae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   56.72%   56.81%   +0.08%     
==========================================
  Files          33       33              
  Lines        2015     2019       +4     
==========================================
+ Hits         1143     1147       +4     
  Misses        872      872              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vpapanasta vpapanasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Christopher.

Is this fixing #35 ?

I think it makes sense to add a test in tests/texampleTests.m to guard against this failure.

@ccreutzi
Copy link
Member Author

ccreutzi commented Jun 6, 2024

Is this fixing #35 ?

It does in my sandbox, yes.

I think it makes sense to add a test in tests/texampleTests.m to guard against this failure.

In my sandbox, texampleTests.m failed because of #35. In the CI, it sometimes does, but often works. I do not know how to write a better test than the existing example.

@ccreutzi ccreutzi merged commit bebf8b2 into main Jun 6, 2024
2 checks passed
@ccreutzi ccreutzi deleted the websave-to-get-images branch June 6, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example UsingDALLEToEditImages errors
3 participants