Skip to content

Commit

Permalink
Fix test infra depending on CI=true
Browse files Browse the repository at this point in the history
The CI env var was recently [changed][1] to be specific for the
application being tested instead of the framework tests. Because of
this, these lines which should have been true before are now false.

[1]: 1f0262a
  • Loading branch information
skipkayhil committed Nov 30, 2023
1 parent c4fbb0f commit 3d002c1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def warn(message, *)

return unless message.include?(PROJECT_ROOT)
return if ALLOWED_WARNINGS.match?(message)
return unless ENV["RAILS_STRICT_WARNINGS"] || ENV["CI"]
return unless ENV["RAILS_STRICT_WARNINGS"] || ENV["BUILDKITE"]

raise message
end
Expand Down
2 changes: 0 additions & 2 deletions tools/test_common.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
ENV.delete("CI") # CI has affect on the applications, and we don't want it applied to the apps.

Minitest::Ci.report_dir = File.join(__dir__, "../test-reports/#{ENV['BUILDKITE_JOB_ID']}")
end

if ENV["CI"]
module DisableSkipping # :nodoc:
private
def skip(message = nil, *)
Expand Down

0 comments on commit 3d002c1

Please sign in to comment.