Unfiltering tests and cleaning up edge-cases #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor changes (mostly resulting from going over all the tests that were filtered or commented out):
With this change, users will have to explicitly cast their fill value to the datasets datatype (which is more cumbersome, but avoids wrong expectations). A bit on the fence about this change, so let me know if you prefer the original approach.
The mismatch in the fill value datatype will now result in a new
MATLAB:zarrcreate:invalidFillValueType
error.Also un-filtering and updating the corresponding
tZarrCreate/invalidFillValue
test.Ensuring the dataset size cannot include zeros or be empty. Un-filtering and updating
tZarrCreate/invalidSizeInput
test.Ensuring the chunk size cannot include zeros or be empty. Un-filtering and updating
tZarrCreate/invalidChunkSize
test.Making
extractS3BucketNameAndPath
into a static method. It is a helper method that does not use anything instance-specific - making it static will allow to unit-test it (see Add test to lock pattern verification for cloud-storage workflows #88 ).Un-filtering and updating
tZarrAttributes/verifyArrayAttributeInfo
andtZarrAttributes/verifyAttrOverwrite
tests (see Attribute transpose and type change behavior looks incorrect #34 - due to JSON limitations, the round-trip of attribute data is imperfect, so we should just capture the current behavior instead of keeping the tests filtered).Adding
tZarrCreate/createDefaultArray
test - I don't think we were previously capturing the behavior of which default attributes zarrcreate generates.