Separate adding .js into a separate PathFilter #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the
normalizepath filter into two separate ones, the first that adds[mathjax]/to relative paths, and a second new one to handle the addition of.jswhen it is missing (which used to be part of thenormalizefilter). The reason for this is so that third-party packages can create a path that includes the complete URL to their package, e.g., xypic can use[xypic]to point to the CDN that serves XyJax. Without this PR, that would be translated to[xypic].js, bynormalizeand then the[xypic]portion would be replaced. So if thexypicpath already included the.js, this would be a problem. (This is actually where I found out about it, as XyJax is being updated.)