Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH workflow to create draft release with built static files #3489

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

pavish
Copy link
Member

@pavish pavish commented Mar 14, 2024

Fixes #2871

Details

  • Adds a workflow that creates a draft release whenever a tag is pushed. This draft release includes the built frontend static files.
    • Tested this on my fork, since this needs to be on the develop branch inorder for us to test it.
  • Updates docs:
    • Removes NodeJS & npm dependencies and downloads & extracts static_files to correct location
    • Adds step to compile the Django translation files (This seems to have been missed previously, I only caught it when adding ja translations).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901
Copy link
Member

@pavish #3198 might be relevant, instead of creating a draft release it creates and uploads static assets once a release is created/edited.

@pavish
Copy link
Member Author

pavish commented Mar 14, 2024

@Anish9901

instead of creating a draft release it creates and uploads static assets once a release is created/edited.

The current plan is to automate creating a draft release with the frontend static assets when a tag is created, when a release branch is cut. Refer this mail thread.

@pavish pavish requested review from seancolsen and Anish9901 March 15, 2024 09:44
@pavish pavish added the pr-status: review A PR awaiting review label Mar 15, 2024
@pavish pavish added this to the v0.1.6 milestone Mar 15, 2024
@pavish pavish marked this pull request as ready for review March 15, 2024 09:45
@pavish
Copy link
Member Author

pavish commented Mar 15, 2024

This introduces changes to our release process. I will raise a separate PR for it on the wiki repo.

@pavish pavish mentioned this pull request Mar 15, 2024
14 tasks
@seancolsen
Copy link
Contributor

@pavish I'm a little confused about the workflow here. You said:

This introduces changes to our release process. I will raise a separate PR for it on the wiki repo.

I think that once I read that PR I'll either be satisfied or I'll have some more specific questions to ask. So I'm going to hold off on reviewing this until I can read the wiki PR in conjunction.

@Anish9901
Copy link
Member

Anish9901 commented Mar 17, 2024

I don't see any releases on the fork you linked @pavish, I think it'd be helpful if you could also link the asset in this PR.

@pavish
Copy link
Member Author

pavish commented Mar 18, 2024

@Anish9901 Draft releases aren't visible. I published it, here's how it looks: https://github.com/pavish/mathesar/releases/tag/0.1.6

@pavish
Copy link
Member Author

pavish commented Mar 18, 2024

I think that once I read that PR I'll either be satisfied or I'll have some more specific questions to ask. So I'm going to hold off on reviewing this until I can read the wiki PR in conjunction

@seancolsen The wiki PR is here: mathesar-foundation/mathesar-wiki#109

Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pavish pavish added this pull request to the merge queue Mar 18, 2024
Merged via the queue into develop with commit 4c92e83 Mar 18, 2024
34 checks passed
@pavish pavish deleted the release_assets branch March 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow people to install Mathesar from source without NodeJS
3 participants