Copy formatted cell values to clipboard instead of raw values #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve readability - Add some more code working towards copy-paste so that the intent is clearer behind the separation of raw vs formatted values.
|
@ghislaineguerin you might also be interested in looking at this since it addresses an issue you originally reported. |
pavish
reviewed
Jul 26, 2023
Comment on lines
124
to
151
| for (const rowId of this.getRowIds(cells)) { | ||
| const plainTextRow: string[] = []; | ||
| const tsvRow: string[] = []; | ||
| const structuredRow: StructuredCell[] = []; | ||
| for (const columnId of this.getColumnIds(cells)) { | ||
| if (isCellSelected(cells, { rowIndex: rowId }, { id: columnId })) { | ||
| const cellText = getCellText( | ||
| indexedRecords, | ||
| processedColumns, | ||
| rowId, | ||
| columnId, | ||
| 'raw', | ||
| recordSummaries, | ||
| ); | ||
| plainTextRow.push(cellText); | ||
| const column = columns.get(columnId); | ||
| if (!isCellSelected(cells, { rowIndex: rowId }, { id: columnId })) { | ||
| // Ignore cells that are not selected. | ||
| continue; | ||
| } | ||
| if (!column) { | ||
| // Ignore cells with no associated column. This should never happen. | ||
| continue; | ||
| } | ||
| const rawCellValue = getRawCellValue(indexedRecords, rowId, columnId); | ||
| const formattedCellValue = getFormattedCellValue( | ||
| rawCellValue, | ||
| columns, | ||
| columnId, | ||
| recordSummaries, | ||
| ); | ||
| const type = column.abstractType.identifier; | ||
| structuredRow.push({ | ||
| type, | ||
| raw: rawCellValue, | ||
| formatted: formattedCellValue, | ||
| }); | ||
| tsvRow.push(formattedCellValue); | ||
| } |
There was a problem hiding this comment.
@seancolsen A minor nitpick.
For cases like these, where we don't have break out of the loop, I'd prefer iterating with forEach and return statements instead of a for loop and continue.
I don't have a major concern towards removing the no-continue rule, but I'm not a fan of continue either.
No action item needed. I only wanted to share this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3085
Notes
Checklist
Update index.md).developbranch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin