Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #[infer] attribute #385

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Remove #[infer] attribute #385

merged 1 commit into from
Dec 4, 2023

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Sep 13, 2023

Made useless by reverse coercions in Coq 8.16

Fixes: #329
Fixes: #327

Overlay

@proux01 proux01 force-pushed the rm_infer branch 2 times, most recently from 0a8153d to 979b327 Compare September 25, 2023 07:21
@proux01 proux01 marked this pull request as ready for review September 25, 2023 11:17
@proux01
Copy link
Contributor Author

proux01 commented Sep 25, 2023

This seems ready

@gares
Copy link
Member

gares commented Sep 25, 2023

@CohenCyril can we simplify further? is phant.* still needed?

@gares gares changed the title Remove #[infer attribute Remove #[infer] attribute Oct 8, 2023
@CohenCyril
Copy link
Member

@CohenCyril can we simplify further? is phant.* still needed?

I think we could simplify a bit more, but I'd rather wait until a checkpoint wrt the unmerged work of Thomas, Paolo and Quentin.

@CohenCyril CohenCyril closed this Nov 30, 2023
@CohenCyril CohenCyril reopened this Nov 30, 2023
@CohenCyril
Copy link
Member

@proux01 I'm in favor of a rebase and merge

CohenCyril
CohenCyril approved these changes Nov 30, 2023
Made useless by reverse coercions in Coq 8.16
@proux01
Copy link
Contributor Author

proux01 commented Dec 1, 2023

@CohenCyril the multinomials failure is a known one math-comp/math-comp#1131 (comment) due to some dune issue following math-comp/multinomials#79 so we can consider the CI "green" and merge I think.

@CohenCyril CohenCyril merged commit b4e8cbc into math-comp:master Dec 4, 2023
104 of 105 checks passed
@proux01 proux01 deleted the rm_infer branch December 4, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants