Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen of int. by subst + normal distribution #1450

Merged
merged 11 commits into from
Feb 19, 2025

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jan 8, 2025

Motivation for this change

PR #1448 should be merged first merged

to be cleaned @IshiguroYoshihiro

The goal of this PR is to provide integration by substitution over unbounded intervals
to compute integrals.

We already had the following lemmas for integration by substitution:

  • integration_by_substitution_decreasing:
    over [F b, F a], decreasing change of vars F
  • integration_by_substitution_oppr:
    over [-b, -a], change of vars (fun x => - x)
  • integration_by_substitution_increasing:
    over [F a, F b], increasing change of vars F

This PR adds integration by substitution for non-negative functions over rays:

  • decreasing_ge0_integration_by_substitutiony:
    over ]-oo, F a], decreasing change of vars F
  • ge0_integration_by_substitutionNy:
    over ]-oo, -a], change of vars (fun x => - x)
  • increasing_ge0_integration_by_substitutiony:
    over [F a, +oo[, increasing change of vars F
    (proved using above lemmas and the properties of negation)
  • increasing_ge0_integration_by_substitutionNy:
    over ]-oo, F b], increasing change of vars F
    (proved using above lemmas and the properties of negation)
  • increasing_ge0_integration_by_substitutionT:
    over ]-oo, +oo[, increasing change of vars F
    (proved using above lemmas)
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

This was referenced Feb 12, 2025
@affeldt-aist affeldt-aist marked this pull request as ready for review February 12, 2025 07:31
@affeldt-aist affeldt-aist requested a review from t6s February 12, 2025 14:07
@affeldt-aist
Copy link
Member Author

@IshiguroYoshihiro I asked Saikawa-san to take a look, but could you also check the contents of this PR?

@affeldt-aist
Copy link
Member Author

affeldt-aist commented Feb 12, 2025

(CI says red but actually compiles fine on my machine with Coq 8.20 and Coq 8.19...) fixed

@affeldt-aist
Copy link
Member Author

@IshiguroYoshihiro no input about this PR?

@affeldt-aist
Copy link
Member Author

@t6s maybe I can add a piece of LaTeXed documentation as for the PR you already just reviewed.

@affeldt-aist
Copy link
Member Author

@t6s maybe I can add a piece of LaTeXed documentation as for the PR you already just reviewed.

image

@affeldt-aist
Copy link
Member Author

We have also added the normal distribution has a direct application.

@affeldt-aist affeldt-aist changed the title tentative gen of int. by subst gen of int. by subst + normal distribution Feb 18, 2025
@affeldt-aist affeldt-aist added this to the 1.9.0 milestone Feb 18, 2025
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Feb 18, 2025
Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an impression from the latex header doc, the statements of the added lemmas look good.
The lemma integralT_gauss is a serious example, and I expect that its proof provide a good test for the added lemmas.
I therefore would like to approve this PR although I myself have not checked all the changes by running them.

@t6s
Copy link
Member

t6s commented Feb 19, 2025

A minor comment: integralT_gauss deserves to be a Theorem not merely a Lemma.

@affeldt-aist affeldt-aist merged commit 3be9b1d into math-comp:master Feb 19, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants