Skip to content

Commit

Permalink
Comment out windows testing for now.
Browse files Browse the repository at this point in the history
  • Loading branch information
@shyuep
shyuep committed Dec 10, 2024
1 parent 534456d commit 817435e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
fail-fast: false
max-parallel: 20
matrix:
os: [ubuntu-latest, macos-14, windows-latest]
os: [ubuntu-latest, macos-14] #, windows-latest]
python-version: ["3.10", "3.12"]

runs-on: ${{ matrix.os }}
Expand Down

1 comment on commit 817435e

@DanielYang59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is due to incorrect matrix variable name (python-version instead of python) :

monty/.github/workflows/test.yml

Lines 10 to 22 in 26acf0b

matrix:
os: [ubuntu-latest, macos-14] #, windows-latest]
python-version: ["3.10", "3.12"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}

Fixed in #732

Please sign in to comment.