improve code coverage by including "symbreak" for chgnet training

[kenko911]

Summary

improve code coverage by including "symbreak" for chgnet training in the united test

Checklist

• Google format doc strings added. Check with ruff.
• Type annotations included. Check with mypy.
• Tests added for new features/fixes.
• If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

[coderabbitai]

Walkthrough

The changes in this pull request focus on enhancing the TestModelTrainer class in the tests/utils/test_training.py file. Key modifications include updates to the CHGNet model's training parameters, the introduction of tests for scenarios involving missing labels and multiple target values, and the addition of a test for CHGNet without magnetic moment labels. These changes aim to improve the robustness and coverage of the testing framework for various models.

Changes

File	Change Summary
tests/utils/test_training.py	- Updated CHGNet initialization to include magmom_target. - Added test_chgnet_training_without_m method to test CHGNet without magnetic moments. - Added test_chgnet_training_with_missing_label method for handling missing labels during training. - Added test_m3gnet_property_trainin_multiple_values_per_target method for testing M3GNet with multiple target values.

Possibly related PRs

• Increase more code coverage in _chgnet.py #261: This PR enhances the testing of the CHGNet model, which is directly related to the changes made in the main PR regarding the CHGNet model's training and testing scenarios.
• Improve the coverage in MLP_norm class #278: This PR improves coverage in the MLP_norm class, which may relate to the overall testing framework improvements in the main PR, although it does not directly modify the same functions or classes.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9632254 and a2c6b80.

📒 Files selected for processing (1)

• tests/utils/test_training.py (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

tests/utils/test_training.py (1)

683-685: Verify that magmom_target is a valid parameter for PotentialLightningModule.

The parameter magmom_target="symbreak" has been added to the PotentialLightningModule initialization. Please ensure that the PotentialLightningModule class's __init__ method accepts this parameter and handles it appropriately.

Run the following script to confirm whether PotentialLightningModule accepts the magmom_target parameter:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.