Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Species.from_string() with Species.from_str() #7

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Oct 4, 2024

pymatgen's Species class no longer has a from_string method. I am guessing this was renamed at some point to be from_str

@tsmathis
Copy link
Collaborator Author

tsmathis commented Oct 7, 2024

now requires a minimum pymatgen version of 2023.7.17, which deprecated the from_string method

@tsmathis tsmathis merged commit 75a88e7 into materialsproject:main Oct 7, 2024
1 of 2 checks passed
@tsmathis tsmathis deleted the update-from-string branch October 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant