Update pourbaix heatmap plots #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing x, y, and z labels on hovertext of heatmaps
for more information, see https://pre-commit.ci
Small color update to ion/default color Removed extra box from hovertext of heatmap off Pourbaix plots.
for more information, see https://pre-commit.ci
Updated some whites to be a bit further offwhite so that it contrasts with the white background. Updated the heatmap color scheme to include the full range but use an exponentially scaled color scheme based off magma.
for more information, see https://pre-commit.ci
JoshuaNgXY
changed the title
JoshuaNgXY
commented
Aug 8, 2024
| ) | ||
| # decomposition_e = np.min( | ||
| # [decomposition_e, np.ones(decomposition_e.shape)], axis=0 | ||
| # ) |
There was a problem hiding this comment.
This must be turned off so that the Gibbs Energy is not capped.
|
Failing in a part of code not edited in this PR. It seems that this failure is common to the repo as other PRs and commits have the same error messages. |
|
@JoshuaNgXY @yang-ruoxi I've fixed the issues with the tests. Feel free to merge and release when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Color change for the regular diagram:
Before
After
Color change for the Heatmap
Before
After