-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Documentation update #850
Conversation
Thanks very much @AntObi for the detailed PR. I'm happy to merge once the CI passes. I think the main issue is the punctuation that was removed. To make things easier, you can install the pre-commit which will catch most things before committing. pip install pre-commit
pre-commit install |
Head branch was pushed to by a user without write access
@utf Thanks for the fast response! You can hold off on merging this PR until I fix the issue with the |
Great work, @AntObi ! Wondering if we should also update the readme? |
Hi @utf @JaGeo , I think this PR will take longer than I expected 😅 .
As I mentioned in the TODO for this PR, some of the subpackages/modules don't have their classes and functions appear in the docs. So far, I haven't been identify the cause of this (likely something I have to dig into Sphinx to find out). @JaGeo What did you have in mind for updates to the README? |
Hi @AntObi. All you should need to do is add the top level links. Sphinx-autodoc should do the rest. Can you try removing the build folder and rebuilding from scratch. Does that help at all? |
Similar to the publication draft, we could list all available calculators and highlight the most important workflows. |
Thanks @AntObi |
* Add new subpackages to index.rst * Autoupdated Enums * Run pre-commit and fix enums * Add correct punctuation and line breaks to CP2K enum generate script --------- Co-authored-by: Alex Ganose <[email protected]>
* Add new subpackages to index.rst * Autoupdated Enums * Run pre-commit and fix enums * Add correct punctuation and line breaks to CP2K enum generate script --------- Co-authored-by: Alex Ganose <[email protected]>
Summary
In the API reference of the current documentation for atomate2, not all of the subpackages and modules are displayed, which means that a new user to atomate2 will not be able to see all the new workflows added (e.g. forcefields, CP2K etc).
TODO (if any)
Checklist
Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running
ruff
andruff format
on your new code. This willautomatically reformat your code to PEP8 conventions and fix many linting issues.
Run ruff on your code.
type check your code.