-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPRester
lazily get endpoint
and api_key
#936
MPRester
lazily get endpoint
and api_key
#936
Conversation
da9bad2
to
b11178c
Compare
endpoint
and api_key
MPRester
lazily get endpoint
and api_key
d2a1fbc
to
479a9ba
Compare
434ed19
to
f740843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @DanielYang59, looks great! esp. those new tests 👍
The test failure is owing to restricted access to repo secret from a fork:
And is passing locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good - I'll try to get it merged and released.
This reverts commit 6435643.
@DanielYang59 release candidate is out for this 🎉 See https://pypi.org/project/mp-api/0.43.0rc0/ |
Great! Thanks a lot for reviewing! |
Summary
endpoint
andapi_key
, to closeMP_API_KEY
is retrieved at import time #935