Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Thermodynamics when loading databases without mobility parameters #12

Merged

Conversation

nury12n
Copy link
Collaborator

@nury12n nury12n commented Sep 17, 2024

This fixes a bug that was introduced in 0.3.1 where the GeneralThermodynamics class would assume that a database would always contain mobility parameters and could build a mobility model.

Changes:

  • GeneralThermodynamics will check if mobility models were built before creating a PhaseRecordFactory
  • State variables used during building of thermodynamic and mobility models will use the GeneralThermodynamics.stateVariables list rather than hard-coding the list several times.
  • Unit test added to make sure a database without mobility terms could be loaded

@nury12n nury12n merged commit f748761 into materialsgenomefoundation:main Sep 17, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant