Github action to publish docker #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjappelbaum
force-pushed
the
master
branch
2 times, most recently
from
74d022b to
9608ef6
Compare
* upon push * using the token * also creating snapshots (for reproducibility) * adding badge for publish action * moving testing script
ltalirz
approved these changes
Jan 24, 2020
|
though we maybe only should publish if the first action was successful ... |
kjappelbaum
pushed a commit
to kjappelbaum/tools-barebone
that referenced
this pull request
Jan 24, 2020
* trigger actions also upon PR
* trigger publish action only for closed PR (maybe set up branch
protection rules to force that CI should not give errors)
added publish to dockerhub action (materialscloud-org#8)
* publish to dockerhub upon push using API tokenn
* also create snapshots (for reproducibility)
* add badge for publish action
* move testing script
Fixing failing build, run actions upon PR
- only trigger publish action for closed PRs (for which the CI ran successfully, maybe set this in branch protection rules)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully addressing #6 .
Let me clean up the commits ....