Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement-506: Add eslint with prettier plugin and integrate it in preversion/release pipeline (Part 1 - config) #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IvanPostu
Copy link
Member

@IvanPostu IvanPostu commented Sep 16, 2024

related to the issue: #506

In this patch I introduced the last version of eslint 9.X and configured it for typescript and added support for prettier.
So now if you run npm run lint it will check all the rules, including prettier ones.

Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@IvanPostu IvanPostu self-assigned this Sep 16, 2024
Comment on lines +35 to 37
"lint": "eslint .",
"test": "npx jasmine-browser-runner runSpecs",
"build": "rollup --config rollup.config.ts --configPlugin @rollup/plugin-typescript",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make test task as npm run jasmine-browser-runner runSpecs because we already have local dependency in the project. npx uses global one so you need to install it the second time, but why?

@IvanPostu
Copy link
Member Author

To enable eslint V9 in VSCode enable the flag as is shown on the screen below:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant