Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add options to M.AutoInit() #505

Open
wants to merge 2 commits into
base: v2-dev
Choose a base branch
from

Conversation

linkdd
Copy link

@linkdd linkdd commented Sep 13, 2024

Proposed changes

The M.AutoInit() function did not allow to pass options to the individual components. This PR introduces an options parameter (optional) allowing the user to configure each component:

M.AutoInit(document.body, {
  Dropdown: {
    constrainWidth: false,
  },
  FloatingActionButtonOptions: {
    toolbarEnabled: true,
  },
})

Screenshots (if appropriate) or codepen:

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io changed the base branch from main to v2-dev September 26, 2024 16:10
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io
Copy link
Member

wuda-io commented Nov 6, 2024

Can you also update the documentation please and make a PR with a short description and the new options.
That would be awesome and we can merge it.
Check out the repo here https://github.com/materializecss/materialize-docs

@linkdd
Copy link
Author

linkdd commented Nov 8, 2024

@wuda-io Not sure if you saw the other PR as requested, but it is done. I hope it's what you wanted. Feel free to ask request any change if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants