Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jobflow example #27

Merged
merged 8 commits into from
Jul 8, 2024
Merged

Update Jobflow example #27

merged 8 commits into from
Jul 8, 2024

Conversation

JaGeo
Copy link
Collaborator

@JaGeo JaGeo commented Jul 2, 2024

@QuantumChemist I am implementing some updates in the next days.

I would also like to check if we can simplify the code if we swtich from Atoms to MSONAtoms in the functions.

@QuantumChemist
Copy link
Collaborator

Okidoki, let me know if I can help somehow. :)

@JaGeo
Copy link
Collaborator Author

JaGeo commented Jul 2, 2024

I will likely ask you for further feedback and ideas. 😀

@JaGeo
Copy link
Collaborator Author

JaGeo commented Jul 3, 2024

@jan-janssen I also tried to make the structures JSON serializable. One just needs to use MSONAtoms(atom_object) as a converter.

Once we have all contributions, we might want to see again how to move forward with regard to a potential publication.

@jan-janssen
Copy link
Member

@jan-janssen I also tried to make the structures JSON serializable. One just needs to use MSONAtoms(atom_object) as a converter.

I agree, while we do not want to define a "Standard", still including the recommendation to choose data types which are JSON-able makes a lot of sense.

Once we have all contributions, we might want to see again how to move forward with regard to a potential publication.

I still try to reach @mbercx

@JaGeo JaGeo changed the title Update Jobflow test Update Jobflow example Jul 8, 2024
@JaGeo JaGeo merged commit 861a119 into materialdigital:main Jul 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants