Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Clarify when completion is invoked in the docs. #82

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Clarify when completion is invoked in the docs. #82

merged 2 commits into from
Nov 30, 2017

Conversation

jverkoey
Copy link
Contributor

No description provided.

@jverkoey jverkoey requested review from samnm and romoore November 30, 2017 16:58
samnm
samnm approved these changes Nov 30, 2017
View reviewed changes
Copy link

@samnm samnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there any way to tell if an animation was cancelled inside the completion block? Or do clients never need to know that?

@jverkoey
Copy link
Contributor Author

Not presently, though I'm open to adding support for that once we find a solid use case.

#83

@jverkoey jverkoey merged commit e7e0ce6 into develop Nov 30, 2017
@jverkoey jverkoey deleted the docs branch November 30, 2017 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samnm samnm samnm approved these changes

@romoore romoore Awaiting requested review from romoore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jverkoey @samnm @kokoro-team