Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vitepress folder icon #2653

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

okineadev
Copy link
Member

@okineadev okineadev commented Oct 31, 2024

Closes #2587

Added VitePress folder icon.

  • Add a new entry for .vitepress in folderIcons array in src/core/icons/folderIcons.ts.
  • Add folder-vitepress.svg and folder-vitepress-open.svg to the icons directory.

For more details, open the Copilot Workspace session.

Fixes #2587

Added VitePress folder icon.

* Add a new entry for `.vitepress` in `folderIcons` array in `src/core/icons/folderIcons.ts`.
* Add `folder-vitepress.svg` and `folder-vitepress-open.svg` to the `icons` directory.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/material-extensions/vscode-material-icon-theme/issues/2587?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions github-actions bot added the 🏞️ icons PR with new icons label Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@okineadev okineadev requested a review from PKief October 31, 2024 18:58
@okineadev okineadev requested a review from Copilot November 4, 2024 17:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

@okineadev okineadev requested a review from PKief November 5, 2024 16:12
@PKief
Copy link
Member

PKief commented Nov 9, 2024

I was wondering if it's better when we align the lightning with the grid:

image

ah, and this one:

image

We could also elaborate how it would look like if we give the lightning a yellow color. I know it's not following our rules, but maybe it looks a little better, not sure.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above 🔝

@PKief PKief force-pushed the main branch 2 times, most recently from 7918c28 to 7cb05b2 Compare November 13, 2024 14:45
@PKief
Copy link
Member

PKief commented Dec 11, 2024

Thanks for updating it, but from my point of view it still looks a little bit off:

image

But not sure, what we can improve here, I just feel like it doesn't fit into our set of icons.

@github-actions github-actions bot added the ❌ failed build Failed build label Jan 6, 2025
@okineadev okineadev changed the title feat: add vitepress folder icon feat: add vitepress folder icon. Jan 6, 2025
@github-actions github-actions bot added the 🔤 invalid title The PR title does not follow the Conventional Commits format label Jan 6, 2025
@okineadev okineadev changed the title feat: add vitepress folder icon. feat: add vitepress folder icon Jan 6, 2025
@github-actions github-actions bot removed the 🔤 invalid title The PR title does not follow the Conventional Commits format label Jan 6, 2025
@PKief PKief force-pushed the main branch 3 times, most recently from bf847b7 to be76a6a Compare January 6, 2025 21:18
@github-actions github-actions bot added the 🔄 workflows GitHub Actions label Jan 6, 2025
@PKief PKief closed this Jan 6, 2025
@PKief PKief force-pushed the okineadev/add-vitepress-icon branch from f952e66 to 8a06ff6 Compare January 6, 2025 22:29
@PKief PKief reopened this Jan 6, 2025
* Changed the fill color of the VitePress folder icons from `#D500F9` to `#7C4DFF` for better visual consistency.
@okineadev okineadev removed the ❌ failed build Failed build label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons 🔄 workflows GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: folder-vitepress
2 participants