Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vhs icon for *.tape files #2608

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

okineadev
Copy link
Contributor

Description

The vhs tape icon would be more appropriate for this file type (*.tape used by https://github.com/charmbracelet/vhs 📼)

Contribution Guidelines

@github-actions github-actions bot added the icons label Sep 22, 2024
@okineadev okineadev changed the title Add **vhs** icon for *.tape files Add vhs icon for *.tape files Sep 22, 2024
Copy link

github-actions bot commented Sep 22, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief
Copy link
Member

PKief commented Sep 24, 2024

Not sure, if we should have a separate icon for this. I don't like the VHS icon that much and I have the feeling that the video icon is quite a good fit for these files already. And with the separate color it's already different to the normal video files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants