Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trigger #2570

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

bart-krakowski
Copy link
Contributor

Description

https://trigger.dev/

@github-actions github-actions bot added the icons label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief
Copy link
Member

PKief commented Sep 6, 2024

The colors are way to bright from my point of view:

image

It's super hard to recognize the motive and I don't like it that way. Any possibility of using another color tone?

@okineadev
Copy link
Contributor

The colors are way to bright from my point of view:

image

It's super hard to recognize the motive and I don't like it that way. Any possibility of using another color tone?

Very toxic color

@mallowigi
Copy link

yikes

Copy link
Contributor

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the colors to match the Material Design palette

icons/folder-trigger-open.svg Outdated Show resolved Hide resolved
icons/trigger-folder.svg Outdated Show resolved Hide resolved
PKief and others added 4 commits September 14, 2024 10:19
Co-authored-by: Okinea Dev <[email protected]>
Signed-off-by: Philipp Kief <[email protected]>
Co-authored-by: Okinea Dev <[email protected]>
Signed-off-by: Philipp Kief <[email protected]>
@okineadev

This comment was marked as outdated.

@@ -597,7 +597,7 @@ export const folderIcons: FolderTheme[] = [
},
{
name: 'folder-hook',
folderNames: ['hook', 'hooks', 'trigger', 'triggers'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned regarding this decision to have another icon for the "trigger" directory than for "triggers". From my point of view this doesn't make much sense. The word "trigger" is too generic to apply a specific icon for it, right? I feel like we should keep a generic trigger folder icon and maybe update only the file icon here. @okineadev what's your opinion regarding this?

Copy link
Contributor

@okineadev okineadev Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned regarding this decision to have another icon for the "trigger" directory than for "triggers". From my point of view this doesn't make much sense. The word "trigger" is too generic to apply a specific icon for it, right? I feel like we should keep a generic trigger folder icon and maybe update only the file icon here. @okineadev what's your opinion regarding this?

This is a controversial issue. Because on the one hand, the official https://trigger.dev/ website clearly shows how the user works in the trigger folder - https://content.trigger.dev/howitworks-compressed-1.mp4

On the other hand, the trigger folder is not used for this framework, but for other tasks

So I think it's better not to add a folder for this framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants