-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trigger #2570
base: main
Are you sure you want to change the base?
feat: trigger #2570
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
yikes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the colors to match the Material Design palette
Co-authored-by: Okinea Dev <[email protected]> Signed-off-by: Philipp Kief <[email protected]>
Signed-off-by: Philipp Kief <[email protected]>
Co-authored-by: Okinea Dev <[email protected]> Signed-off-by: Philipp Kief <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
@@ -597,7 +597,7 @@ export const folderIcons: FolderTheme[] = [ | |||
}, | |||
{ | |||
name: 'folder-hook', | |||
folderNames: ['hook', 'hooks', 'trigger', 'triggers'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned regarding this decision to have another icon for the "trigger" directory than for "triggers". From my point of view this doesn't make much sense. The word "trigger" is too generic to apply a specific icon for it, right? I feel like we should keep a generic trigger folder icon and maybe update only the file icon here. @okineadev what's your opinion regarding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned regarding this decision to have another icon for the "trigger" directory than for "triggers". From my point of view this doesn't make much sense. The word "trigger" is too generic to apply a specific icon for it, right? I feel like we should keep a generic trigger folder icon and maybe update only the file icon here. @okineadev what's your opinion regarding this?
This is a controversial issue. Because on the one hand, the official https://trigger.dev/ website clearly shows how the user works in the trigger
folder - https://content.trigger.dev/howitworks-compressed-1.mp4
On the other hand, the trigger folder is not used for this framework, but for other tasks
So I think it's better not to add a folder for this framework.
ed9ed26
to
55e5e9c
Compare
Description
https://trigger.dev/