fix(select): close select on menu close #4889
Open
+45
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some situations where the menu can close when the outer select is still open and unaware.
For example, clicking the field will open the menu, then clicking it again will close the menu but not the select.
This is because the menu observes outside clicks in order to close itself. We don't currently observe those closes to update our own state inside
md-select
, so the UI still shows as if it is open but without a menu.The fix here is to always reflect the state of the menu on
closed
.Example of this bug: