Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react_todo-app #1126

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

react_todo-app #1126

wants to merge 3 commits into from

Conversation

Alex-redman
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Feb 22, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
You need to fix the UI bug with input width
image
image

It is also a bad practice to write all the code in one component, you need to separate the logic into different components. For example Header, Footer, TodoItem, TodoList

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-redman @volodymyr-soltys97