Solution #1063
Open
Solution #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RostyslavSharuiev
commented
Oct 12, 2024
RostyslavSharuiev
commented
- DEMO LINK
igorkruz
suggested changes
Oct 14, 2024
src/components/Footer/Footer.tsx
Outdated
Comment on lines
12
to
13
| const completedTodosCount = todos.filter(todo => todo.completed).length; | ||
| const uncompletedTodos = todos.filter(todo => !todo.completed); |
src/components/Footer/Footer.tsx
Outdated
Comment on lines
41
to
43
| onClick={() => | ||
| dispatch({ type: 'setFilter', payload: filterTitle }) | ||
| } |
There was a problem hiding this comment.
create a handle function for this logic
| })} | ||
| onDoubleClick={() => setIsEditing(true)} | ||
| > | ||
| <label className="todo__status-label"> |
There was a problem hiding this comment.
label element should be associated with a form control.
To fix this, you should use the htmlFor attribute on the label to associate it with the checkbox input.
src/components/TodoItem/TodoItem.tsx
Outdated
Comment on lines
80
to
82
| // else { | ||
| // document.addEventListener('keyup', handleKeyUp); | ||
| // } |
There was a problem hiding this comment.
Lets make your code clean, remove committed code.
src/index.tsx
Outdated
Comment on lines
4
to
5
| // import './styles/todo-list.scss'; | ||
| // import './styles/filters.scss'; |
src/components/TodoItem/TodoItem.tsx
Outdated
Comment on lines
67
to
74
| const handleKeyUp = (event: KeyboardEvent) => { | ||
| if (event.key === 'Escape') { | ||
| setIsEditing(false); | ||
| setTitle(todo.title); | ||
| } else if (event.key === 'Enter') { | ||
| handleTitleSave(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
The 'handleKeyUp' function makes the dependencies of useEffect Hook change on every render. Alternatively, wrap the definition of 'handleKeyUp' in its own useCallback() Hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.