Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task #3454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task #3454

wants to merge 1 commit into from

Conversation

dimqee
Copy link

@dimqee dimqee commented Mar 4, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Sum component! 🎉 You've ensured that it handles default values for a and b, which means it won't break even if some props are missing. This is a crucial aspect of making your component robust. Keep up the excellent work, and continue to pay attention to these important details! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

{/* And remove commented lines :) */}
<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing the b prop. Ensure that the Sum component can handle cases where b is undefined, or provide a default value for b.

<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />
<Sum a={5} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing the b prop. Ensure that the Sum component can handle cases where b is undefined, or provide a default value for b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants