-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #3441
base: master
Are you sure you want to change the base?
Develop #3441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉 Your implementation of the Sum
component is spot on, handling all cases where props might be missing by using default values. This ensures that the component functions correctly even when not all props are provided. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
{/* And remove commented lines :) */} | ||
<Sum a={2} b={3} /> | ||
<Sum a={-5} b={5} /> | ||
<Sum a={10} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is used here with only one prop a
. Ensure that the Sum
component can handle cases where one of the props is missing. If it requires both a
and b
, this might cause an error.
<Sum a={2} b={3} /> | ||
<Sum a={-5} b={5} /> | ||
<Sum a={10} /> | ||
<Sum b={5} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is used here with only one prop b
. Similar to the previous line, ensure that the Sum
component can handle cases where one of the props is missing.
<Sum a={-5} b={5} /> | ||
<Sum a={10} /> | ||
<Sum b={5} /> | ||
<Sum /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is used here without any props. Ensure that the Sum
component can handle cases where both props are missing, or provide default values if necessary.
https://Wasd227.github.io/react_sum/