Develop #3439
Develop #3439
Conversation
Feature/prettier
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets the task requirements and constraints effectively. While there are a few minor suggestions for improvement, such as updating the actions/setup-node to v3, ensuring the reports directory is configured correctly, and adjusting the viewport dimensions, these do not impact the core functionality. Keep up the excellent work, and consider these enhancements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| module.exports = { | ||
| env: { | ||
| browser: true, | ||
| es2024: true, |
There was a problem hiding this comment.
The es2024 environment is specified, which might not be supported by ESLint. Consider using es2021 or the latest supported version instead to ensure compatibility.
| @@ -11,19 +11,21 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [14.x] | |||
| node-version: [20.x] | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Use Node.js ${{ matrix.node-version }} | |||
| uses: actions/setup-node@v1 | |||
There was a problem hiding this comment.
Consider updating actions/setup-node to v3 for improved features and security updates. The current version v1 is outdated.
| - run: npm install | ||
| - run: npm test -- -l | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: report | ||
| path: reports |
There was a problem hiding this comment.
Ensure that the reports directory exists and is correctly configured to store the test reports. This is necessary for the upload-artifact action to work properly.
| viewportHeight: 1920, | ||
| viewportWidth: 1080, |
There was a problem hiding this comment.
The viewport dimensions seem inverted. Typically, viewportWidth should be smaller than viewportHeight. Consider swapping these values to better reflect common screen dimensions.
[DEMO LINK] (https://kami2693.github.io/react_sum/)