-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #3438
base: master
Are you sure you want to change the base?
Solution #3438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this task! 😊 It seems there are a few adjustments needed to meet the task requirements. Specifically, the prop values for the Sum
components in the App.jsx
file need to be updated to match the specified pairs in the task description. Once these changes are made, your solution will be spot on! Keep up the great work, and feel free to reach out if you need any help. 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/App.jsx
Outdated
<p>Sum of 0 and 0 is 0</p> | ||
{/* Replace paragraphs with Sum componets */} | ||
{/* And remove commented lines :) */} | ||
<Sum a={7} b={10} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task description requires a = 2
and b = 3
for the first Sum
component. Please adjust the values accordingly.
src/App.jsx
Outdated
{/* Replace paragraphs with Sum componets */} | ||
{/* And remove commented lines :) */} | ||
<Sum a={7} b={10} /> | ||
<Sum a={6} b={-4} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task description specifies a = -5
and b = 5
for the second Sum
component. Please update the values to match this requirement.
src/App.jsx
Outdated
<Sum a={7} b={10} /> | ||
<Sum a={6} b={-4} /> | ||
<Sum a={-40} b={-2} /> | ||
<Sum a={6} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the fourth Sum
component, the task requires only a = 10
. Please update the value to match this requirement.
src/App.jsx
Outdated
<Sum a={6} b={-4} /> | ||
<Sum a={-40} b={-2} /> | ||
<Sum a={6} /> | ||
<Sum b={12} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task specifies that the fifth Sum
component should have only b = 5
. Please adjust the value accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission! 🎉 While your code is on the right track, there are a few areas that need attention to fully meet the task requirements:
-
Incorrect Prop Values in
App.jsx
: Ensure theSum
components have the correct prop values as specified:a = 2
andb = 3
a = -5
andb = 5
- just
a = 10
- just
b = 5
- no params at all
Currently, there's an extra
Sum
component witha = -40
andb = -2
, which is not required. -
Code Style in
Sum.jsx
: Implement string interpolation for rendering the paragraph content to align with the code style guidelines.
These adjustments are crucial for the functionality and style of your code. Please review the comments and make the necessary changes to improve your solution. Remember, addressing these issues will enhance your coding skills and help you avoid similar problems in the future. Keep up the good work and continue learning! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<Sum a={2} b={3} /> | ||
<Sum a={-5} b={5} /> | ||
<Sum a={-40} b={-2} /> | ||
<Sum a={10} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is missing the b
prop. According to the task description, each Sum
component should have both a
and b
props specified.
<Sum a={-5} b={5} /> | ||
<Sum a={-40} b={-2} /> | ||
<Sum a={10} /> | ||
<Sum b={5} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is missing the a
prop. According to the task description, each Sum
component should have both a
and b
props specified.
<Sum a={-40} b={-2} /> | ||
<Sum a={10} /> | ||
<Sum b={5} /> | ||
<Sum /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is missing both a
and b
props. According to the task description, each Sum
component should have both a
and b
props specified.
No description provided.