-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
my solution #3433
base: master
Are you sure you want to change the base?
my solution #3433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Sum
component! 🎉 It correctly defaults a
and b
to 0
when they are not provided, which aligns perfectly with the task requirements. Keep up the excellent work and continue to pay attention to such details. Well done! 👏
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<p>Sum of 0 and 0 is 0</p> | ||
<Sum a={2} b={3} /> | ||
<Sum a={-5} b={5} /> | ||
<Sum a={10} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is missing the b
prop. According to the task requirements, if a
or b
are not passed, they should default to 0
. Ensure that the Sum
component handles this correctly, which it does, but verify that this is the intended usage.
<Sum a={2} b={3} /> | ||
<Sum a={-5} b={5} /> | ||
<Sum a={10} /> | ||
<Sum b={5} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is missing the a
prop. According to the task requirements, if a
or b
are not passed, they should default to 0
. Ensure that the Sum
component handles this correctly, which it does, but verify that this is the intended usage.
<Sum a={-5} b={5} /> | ||
<Sum a={10} /> | ||
<Sum b={5} /> | ||
<Sum /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sum
component is missing both a
and b
props. According to the task requirements, if a
or b
are not passed, they should default to 0
. Ensure that the Sum
component handles this correctly, which it does, but verify that this is the intended usage.
No description provided.