-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'An uncaught error' test #1412
base: master
Are you sure you want to change the base?
'An uncaught error' test #1412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привіт, бачу в тебе якась помилка, я теж не знаю, тому апрувну, щоб перевірка пішла далі, але я б додала логіку отримання користувачів та коментарів в окремі функції - getUserById та getCommentsByPostId, але це не супер критично
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your implementation! 🎉 The code mostly meets the task requirements, with only a minor issue regarding a typo in the prop name coment
in the CommentInfo.jsx
file. Make sure to correct it to comment
to ensure consistency and avoid potential bugs. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -1 +1,15 @@ | |||
export const CommentInfo = () => <>Put the comment here</>; | |||
export const CommentInfo = ({ coment }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the prop name coment
. It should be comment
to match the typical spelling and likely the intended usage. Ensure that this change is reflected wherever this component is used.
comments.length > 0 ? ( | ||
<div className="CommentList"> | ||
{comments.map(comment => ( | ||
<CommentInfo coment={comment} key={comment.id} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prop name coment
is misspelled. It should be comment
to match the expected prop name in the CommentInfo
component. Ensure consistency in prop names across components.
DEMO LINK