Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #1411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #1411

wants to merge 1 commit into from

Conversation

mmaryblackk
Copy link

Copy link

@PiekharievaK PiekharievaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code is well-structured and meets the task requirements effectively. The only minor suggestion is to remove the unnecessary || null in the getCommentsByPostId function, as the filter method already returns an array. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +13 to +14
return (
commentsFromServer.filter(comment => comment.postId === postId) || null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of || null is unnecessary here. The filter method will always return an array, so there is no need to default to null. You can simply return the result of the filter method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants