Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task solution #1407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DariaRadtkina
Copy link

Copy link

@daniil-trusov daniil-trusov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! One small improvement can be made, but it doesn't affect solution logic. Please check comment for details.

export const PostInfo = ({ post }) => (
<div className="PostInfo">
<div className="PostInfo__header">
<h3 className="PostInfo__title">{post.title}</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid writing "post." many times, you can destructure it into separate fields:

{
const {title, user, comments...} = post;
return (
  ...
  <h3> {title} </h3>
  ...
);
}

Same for CommentInfo

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 Your code meets the core requirements, and you've done well in splitting the App into components and ensuring the correct use of keys in iterations. The only minor issue is the separation of styles from App.scss into the respective component style files, but this doesn't impact the functionality. Keep up the good work, and consider addressing the style separation in future projects for better maintainability. Well done! 👏

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants