Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SofiiaPelenska
Copy link

Copy link

@AnOvramenko AnOvramenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on the implementation! 🎉 Your code is well-structured and meets most of the task requirements. The components are effectively split and styled, and the data preparation is correctly handled. The only minor issue is the misleading function name getCommentById. Consider renaming it to better reflect its functionality. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +12 to +14
function getCommentById(postId) {
return commentsFromServer.filter(comment => comment.postId === postId);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function getCommentById might be misleadingly named, as it returns all comments for a given post ID, not a single comment by its ID. Consider renaming it to something like getCommentsByPostId to better reflect its functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants