Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

NataliiaCode
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured, and you've effectively used components to manage data and rendering. While the use of comment.name as a key in CommentList.jsx could potentially lead to issues if names are not unique, this is a minor concern. If possible, consider using a unique identifier like comment.id in the future to ensure uniqueness. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +6 to +7
{comments.map(comment => (
<CommentInfo key={comment.name} comment={comment} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using comment.name as the key prop might not be unique if there are multiple comments with the same name. Consider using a unique identifier like comment.id if available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants