static-list resolving #1391
static-list resolving #1391
Conversation
|
|
||
| <p> | ||
| {' Posted by '} | ||
| console.log(posts) |
There was a problem hiding this comment.
Better to delete console.log before committing.
There was a problem hiding this comment.
Great job on implementing the task! 🎉 Your code meets the requirements and is well-structured. While there are a couple of minor suggestions, such as renaming the PostList component to better reflect its functionality and adding a semicolon after import statements, these do not impact the functionality. Keep up the good work and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| import postsFromServer from './api/posts.json'; | ||
| import commentsFromServer from './api/comments.json'; | ||
| import usersFromServer from './api/users.json'; | ||
| import { PostList } from './components/PostList' |
There was a problem hiding this comment.
It's a good practice to add a semicolon at the end of import statements to avoid potential issues in environments that require semicolons.
| export const PostList = () => <>Put the list here</>; | ||
| import { PostInfo } from '../PostInfo' | ||
|
|
||
| export const PostList = ({ post }) => { |
There was a problem hiding this comment.
The component name PostList implies it should handle multiple posts, but it currently only handles a single post. Consider renaming the component to better reflect its functionality or modifying it to handle an array of posts.
https://reb0rned.github.io/react_static-list-of-posts-js/